🐛 upgrade golangci-lint to v1.61.0 #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
sivchari
changed the title
sivchari
force-pushed
the
upgrade-golangci
branch
from
409f39c to
469e9d1
Compare
k8s-ci-robot
added
size/S
sivchari
force-pushed
the
upgrade-golangci
branch
3 times, most recently
from
b497534 to
e96da8a
Compare
sbueringer
reviewed
Sep 21, 2024
k8s-ci-robot
added
size/XS
sivchari
force-pushed
the
upgrade-golangci
branch
2 times, most recently
from
bdef91f to
dbfe115
Compare
sbueringer
reviewed
Oct 6, 2024
sbueringer
added
the
tide/merge-method-squash
Member
|
@sivchari Do you have time to address the findings? I might need this PR so I can bump to Kubernetes v1.32 alpha.1 |
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sbueringer
force-pushed
the
upgrade-golangci
branch
from
dbfe115 to
9f7ae89
Compare
Member
|
Pushed a small commit to fix the remaining findings /assign @alvaroaleman @vincepri |
sbueringer
force-pushed
the
upgrade-golangci
branch
from
9f7ae89 to
e60ba99
Compare
vincepri
approved these changes
Oct 11, 2024
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 87d1795e2309fe85aa424722590c3cb873d1b03a
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivchari, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
|
@sbueringer |
Member
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgade the golangci-lint version to v1.61.0.